Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tabs for create/load dataset steps #328

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Use tabs for create/load dataset steps #328

merged 1 commit into from
Nov 10, 2023

Conversation

aidazolic
Copy link
Contributor

Replaces expanders with tabs on the create new / load existing configuration page.

@aidazolic aidazolic requested a review from a team as a code owner November 10, 2023 10:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@aidazolic aidazolic self-assigned this Nov 10, 2023
@aidazolic aidazolic marked this pull request as draft November 10, 2023 11:04
marcenacp
marcenacp approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can you change the selector in the test ([data-testid="stExpander"]) with the new selector for tabs?

wizard/views/overview.py Show resolved Hide resolved
@aidazolic aidazolic marked this pull request as ready for review November 10, 2023 16:30
@aidazolic
Copy link
Contributor Author

LGTM, thanks!

Can you change the selector in the test ([data-testid="stExpander"]) with the new selector for tabs?

I modified the tests.
Can you PTAL again? Thanks!

@aidazolic aidazolic closed this Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@aidazolic aidazolic reopened this Nov 10, 2023
marcenacp
marcenacp approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@marcenacp marcenacp merged commit 634c201 into mlcommons:main Nov 10, 2023
26 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcenacp marcenacp marcenacp approved these changes

Assignees

@aidazolic aidazolic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidazolic @marcenacp