Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys in a RecordSet should be a list of ids references. #740

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Conversation

ccl-core
Copy link
Contributor

@ccl-core ccl-core commented Sep 20, 2024

As keys, RecordSets in Croissant accept a list of dictionaries in the form:

  1. "key": [{ "@id": "ratings/user_id" }, { "@id": "ratings/movie_id" }],
  2. "key": { "@id": "ratings/user_id" },

As indicated the specs.

Plain keys such as "key": "ratings/user_id" are not accepted anymore.

@ccl-core ccl-core requested a review from a team as a code owner September 20, 2024 12:08
Copy link

github-actions bot commented Sep 20, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@ccl-core ccl-core changed the title List of keys Accept a list of dictionaries as keys. Sep 20, 2024
@ccl-core ccl-core changed the title Accept a list of dictionaries as keys. Keys in a RecordSet should be a list of ids references. Sep 20, 2024
Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ccl-core ccl-core merged commit c355ffc into main Sep 23, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants