Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Options to validate #293

Merged
merged 16 commits into from
Aug 12, 2024
Merged

Feature - Options to validate #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5a51756
Create SelectMultipleTextMultipleTags
shincap8 Jul 10, 2024
47234c9
Merge branch 'main' of https://github.com/mlcommons/dynabench into Fe…
shincap8 Jul 11, 2024
e02a49d
Multiple colors and tags working allong with dropdown search
shincap8 Jul 12, 2024
48aa044
Merge branch 'main' of https://github.com/mlcommons/dynabench into Fe…
shincap8 Jul 19, 2024
87bd3f8
Extract random color function from component
shincap8 Jul 22, 2024
e6dc1cb
Use content from endpoint and implement back_label
shincap8 Jul 24, 2024
1de0e69
Merge branch 'main' of https://github.com/mlcommons/dynabench into Fe…
shincap8 Jul 25, 2024
881be20
Select Multiple tags component
shincap8 Jul 30, 2024
1b63ee2
missing creation interface option update
shincap8 Jul 30, 2024
6d3ab93
change name of tooltip instruction variable
shincap8 Jul 30, 2024
931bb76
Merge branch 'main' of https://github.com/mlcommons/dynabench into Fe…
shincap8 Jul 31, 2024
7ebfda0
move dropdown to top add loading after example submition add button t…
shincap8 Aug 1, 2024
93f0aaf
Merge branch 'main' of https://github.com/mlcommons/dynabench into Fe…
shincap8 Aug 7, 2024
57b7f47
use regex for any kind of spaces for token split
shincap8 Aug 7, 2024
32c6ead
Add Validation Options to allow user use their own options to validate
shincap8 Aug 9, 2024
e299c55
add safe and unsafe to the enum in the validation table
shincap8 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/app/domain/services/base/example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ def get_validate_configuration(self, task_id: int) -> dict:
context_info = {
"validation_user_input": config_yaml.get("validation_user_input"),
"validation_context": config_yaml.get("validation_context"),
"validation_options": config_yaml.get("validation_options"),
}
return context_info

Expand Down
4 changes: 3 additions & 1 deletion backend/app/infrastructure/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,9 @@ class Validation(Base):
id = Column(Integer, primary_key=True)
uid = Column(ForeignKey("users.id"), index=True)
eid = Column(ForeignKey("examples.id"), nullable=False, index=True)
label = Column(Enum("flagged", "correct", "incorrect", "placeholder"))
label = Column(
Enum("flagged", "correct", "incorrect", "placeholder", "safe", "unsafe")
)
mode = Column(Enum("user", "owner"))
metadata_json = Column(Text)

Expand Down
2 changes: 1 addition & 1 deletion ...ateSamples/CreateSamples/AnnotationInterfaces/Contexts/SelectMultipleTextMultipleTags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ const SelectMultipleTextMultipleTags: FC<
</div>
</div>
<TokenAnnotator
tokens={text.split(" ")}
tokens={text.split(/\s/g)}
value={selectionInfo}
onChange={(value) => handleChange(value)}
getSpan={(span) => ({
Expand Down
8 changes: 7 additions & 1 deletion frontends/web/src/new_front/pages/CreateSamples/ValidateSamples.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,13 @@ const ValidateSamples: FC = () => {
)}
<RadioButton
instructions="Actions"
options={["👍 Correct", "👎 Incorrect", "🚩 Flag"]}
options={
validationConfigInfo.validation_options || [
"👍 Correct",
"👎 Incorrect",
"🚩 Flag",
]
}
field_name_for_the_model="label"
onInputChange={(input) => {
setLabel(input.label);
Expand Down
1 change: 1 addition & 0 deletions frontends/web/src/new_front/types/createSamples/createSamples/configurationTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export type ConfigurationTask = {
export type ValidationConfigurationTask = {
validation_user_input: object[];
validation_context: object[];
validation_options?: string[];
};

type ModelOutput = {
Expand Down
Loading