Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Enhance multigenerator and image generators #298

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

shincap8
Copy link
Contributor

@shincap8 shincap8 commented Aug 27, 2024

Context

  • Nibbler needs more dalle images generated, and there were some models throwing errors.

Changes Made

  1. Add more dalle2 and 3 providers.
  • This would allow the user to see more images generated by this models.
  1. Improve the way several providers are created, passing the model_instance.
  • This would allow us to have cleaner code, shorter files and avoid repeating lines.
  1. Fix the way SDXLImageProvider parse its response to avoid errors.
  • This would allow us to use those models avoiding errors when parsing.
  1. Delete SDXLImageProvider with model instance sdxl1 (this is the model remove from huggingface).
  • This would allow us not to use a model that we remove from huggingface.
image image image image image image

@shincap8 shincap8 requested a review from a team as a code owner August 27, 2024 23:54
Copy link

github-actions bot commented Aug 27, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@shincap8 shincap8 merged commit 9bf4781 into main Aug 30, 2024
13 checks passed
@shincap8 shincap8 deleted the Fix/enhance_multigenerator branch August 30, 2024 21:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants