Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update - Nibbler Placeholder #307

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Update - Nibbler Placeholder #307

merged 4 commits into from
Sep 23, 2024

Conversation

shincap8
Copy link
Contributor

Context

  • Nibbler's input placeholder isn't disappearing after user inputs something, this causes for prompts to be send with part of the placeholder.

Changes Made

  1. Match the comparison of the placeholder in the BasicInputRemain component with the current placeholder of the round.
  • This would allow the placeholder to disappear after the user interacts with the input.

@shincap8 shincap8 requested a review from a team as a code owner September 20, 2024 21:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@shincap8 shincap8 merged commit 9342d65 into main Sep 23, 2024
13 checks passed
@shincap8 shincap8 deleted the Update/Nibbler_Placeholder branch September 23, 2024 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remg1997 remg1997 remg1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shincap8 @remg1997