Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve speed in hilbert transform by FFT #284

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Jan 20, 2025

No description provided.

@jobo322 jobo322 requested a review from josoriom January 20, 2025 14:29
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (165bf0e) to head (74bd954).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   96.39%   96.39%   -0.01%     
==========================================
  Files         184      184              
  Lines        5164     5161       -3     
  Branches     1151     1150       -1     
==========================================
- Hits         4978     4975       -3     
  Misses        186      186              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the result is the same and the algorithm is faster this PR is ok for me.

@lpatiny
Copy link
Member

lpatiny commented Feb 22, 2025

@jobo322 why was this PR not merged ? Did you do any benchmark ? Do you know how much faster it is ?

@jobo322
Copy link
Member Author

jobo322 commented Feb 26, 2025

from the README of fft.js it may run 25% faster, but seems the improvement in speed is not than good as 25 %. at least it avoid the for loop

@jobo322 jobo322 force-pushed the improve-hilbert-transform branch from 9f540ce to 74bd954 Compare February 26, 2025 19:22
@jobo322 jobo322 merged commit fc7dfd6 into main Feb 26, 2025
10 checks passed
@jobo322 jobo322 deleted the improve-hilbert-transform branch February 26, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants