Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return child process and add optional options to webdriver_standalone. #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return child process and add optional options to webdriver_standalone. #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f4aa3
return webdriver standalone child process
t1bb4r Aug 12, 2016
b083b3c
Allow optional options to webdriver_standalone
t1bb4r Aug 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,11 @@ var webdriver_update_specific = function(opts) {

webdriver_update.bind(null, ["ie", "chrome"])

var webdriver_standalone = function(cb) {
var child = child_process.spawn(path.resolve(getProtractorDir() + '/webdriver-manager'+winExt), ['start'], {
stdio: 'inherit'
}).once('close', cb);
var webdriver_standalone = function(opts, cb) {
var callback = (cb ? cb : opts);
var options = (cb ? opts : {});
return child = child_process.spawn(path.resolve(getProtractorDir() + '/webdriver-manager'+winExt), ['start'], options
).once('close', cb);
};

module.exports = {
Expand Down