Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: offset column role in Task #1225

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat: offset column role in Task #1225

wants to merge 21 commits into from

Conversation

bblodfon
Copy link
Contributor

@bblodfon bblodfon commented Dec 4, 2024 •
edited
Loading

  • Properly support offset for mlr3 learners
    • Some TODOs left (talked with Marc)
  • xgboost in mlr3learners uses this now mlr3learners PR
  • See mlr3proba PR for the PEM reduction pipeline (surv => regr) that uses this

@bblodfon bblodfon requested a review from be-marc December 4, 2024 16:31
@be-marc be-marc changed the title Add offset col_role in Task feat: offset column role in Task Jan 16, 2025
@bblodfon bblodfon mentioned this pull request Jan 21, 2025
Open
sebffischer
sebffischer reviewed Jan 24, 2025
View reviewed changes
R/Task.R
stopf("Offset column(s) %s must be a numeric or integer column", paste0("'", new_roles[["offset"]], "'", collapse = ","))
}

if (any(task$missings(cols = new_roles[["offset"]]) > 0)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a shorter circuit (something like mlr3misc::some)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebffischer sebffischer sebffischer left review comments

@be-marc be-marc Awaiting requested review from be-marc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bblodfon @sebffischer @be-marc