Skip to content

Commit

Permalink
mini fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
mb706 authored Nov 19, 2024
1 parent 2da70ab commit c87253e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# mlr3pipelines 0.7.9000
# mlr3pipelines 0.7.1-9000

* New parameter `no_collapse_above_absolute` in `PipeOpCollapseFactors` / `po("collapse_factors")`.
* Fix: `PipeOpCollapseFactors` now correctly collapses levels of ordered factors.
Expand Down
2 changes: 1 addition & 1 deletion R/PipeOpCollapseFactors.R
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ PipeOpCollapseFactors = R6Class("PipeOpCollapseFactors",
initialize = function(id = "collapsefactors", param_vals = list()) {
ps = ps(
no_collapse_above_prevalence = p_dbl(0, 1, tags = c("train", "predict")),
no_collapse_above_absolute = p_int(1, special_vals = list(Inf), tags = c("train", "predict")),
no_collapse_above_absolute = p_int(0, special_vals = list(Inf), tags = c("train", "predict")),
target_level_count = p_int(2, tags = c("train", "predict"))
)
ps$values = list(no_collapse_above_prevalence = 1, no_collapse_above_absolute = Inf, target_level_count = 2)
Expand Down

0 comments on commit c87253e

Please sign in to comment.