Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipeOpRowApply #785

Merged
merged 16 commits into from
Aug 6, 2024
Merged

PipeOpRowApply #785

merged 16 commits into from
Aug 6, 2024

Conversation

advieser
Copy link
Collaborator

Closes #318

New PipeOp inheriting from PipeOpTaskPreprocSimple.
This works by calling apply on the task data with FUN = applicator (param of the PO) and simplify = TRUE. This should return a matrix or a vector. If a list is returned, an error is thrown.
The rest of the code is there

  • to handle the differences between vectors and matrices returned by apply.
  • to create column names automatically, that might have been dropped by apply (depends on the applicator).
  • to handle tasks with zero rows.

Tests might be a bit too excessive (?), I tried to cover all the points I talked about with @mb706.

R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
R/PipeOpRowApply.R Outdated Show resolved Hide resolved
@mb706 mb706 merged commit 63b8c27 into master Aug 6, 2024
4 checks passed
@mb706 mb706 deleted the PipeOpRowApply branch August 6, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing PipeOpRowApply
2 participants