Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PipeOpTaskPreproc should work with features that also have other roles #866

Merged
merged 8 commits into from
Jan 21, 2025
Merged

PipeOpTaskPreproc should work with features that also have other roles #866

merged 8 commits into from
Jan 21, 2025

Conversation

mb706
Copy link
Collaborator

@mb706 mb706 commented Jan 16, 2025

Let's see if this makes any problems
closes #864

@mb706
Copy link
Collaborator Author

mb706 commented Jan 16, 2025

@advieser could you add a test to check if this solves #864 ?

mb706
mb706 commented Jan 21, 2025
View reviewed changes
tests/testthat/test_pipeop_task_preproc.R Outdated Show resolved Hide resolved
tests/testthat/test_pipeop_task_preproc.R Outdated Show resolved Hide resolved
@advieser advieser merged commit 2f8c355 into master Jan 21, 2025
4 checks passed
@advieser advieser deleted the handle_multi_role_cols branch January 21, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@advieser advieser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph resets custom col roles after training
2 participants
@mb706 @advieser