feat(check): better error message when measure's minimize is NA (#485)

mlr-org · Jan 13, 2025 · 535c418 · 535c418
1 parent 9a5a587
commit 535c418
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/R/helper.R b/R/helper.R
@@ -1,6 +1,9 @@
 measures_to_codomain = function(measures) {
   measures = as_measures(measures)
   domains = map(measures, function(s) {
+    if (is.na(s$minimize)) {
+      stopf("Measure %s has its `minimize` field set to NA, which is disallowed when tuning.", s$id)
+    }
     p_dbl(tags = ifelse(s$minimize, "minimize", "maximize"))
   })
   names(domains) = ids(measures)

diff --git a/man/AutoTuner.Rd b/man/AutoTuner.Rd
diff --git a/man/mlr_tuners_cmaes.Rd b/man/mlr_tuners_cmaes.Rd
diff --git a/tests/testthat/test_Tuner.R b/tests/testthat/test_Tuner.R
@@ -434,3 +434,15 @@ test_that("Can only pass internal tune tokens one way", {
     term_evals = 2),
     "Either tag parameters")
 })
+
+test_that("Correct error when minimize is NA", {
+  m = msr("classif.acc")
+  m$minimize = NA
+  expect_error(tune(
+    tuner = tnr("random_search"),
+    task = tsk("iris"),
+    learner = lrn("classif.debug", x = to_tune()),
+    resampling = rsmp("holdout"),
+    measure = m
+  ), "`minimize`")
+})