Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collisions visualizer toggler #132

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TheCodeTherapy
Copy link
Contributor

This PR aims to refactor the creation of the CollisionsManager visual helpers so they can dynamically added and removed from the scene.

When creating MML objects dynamically for a 3D web experience, the CollisionsManager visual helpers have proven to be very handy in inspecting the scene in cases when objects overlap (sometimes causing depth sorting visual glitches that are hard to spot on a first look).

As we already have them anyway under a debug flag in the CollisionsManager class, it would be helpful to be able to toggle them on and off dynamically.

What kind of change does your PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Refactor
  • Tests
  • Other, please describe:

Does your PR fulfill the following requirements?

  • The title references the corresponding issue # (if relevant)
2024-05-11.16-10-14.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant