Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added reposing and geometry merging steps and fixed rotate root #37

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Added reposing and geometry merging steps and fixed rotate root #37

merged 4 commits into from
Jan 22, 2024

Conversation

MarcusLongmuir
Copy link
Contributor

This PR fixes a few issues that plagued some assets we threw at it.

Notably:

  • Geometries that share materials are merged to avoid having many distinct geometries in the export
  • Skeletons are posed back into the bind pose of the mesh(es) to simplify (and fixes some processes applied in later steps).
  • Fixed an issue where the rotate root step would not invert the z position of children correctly (unnoticed previously as it is nearly always zero).

Before
image

After
image

What kind of change does your PR introduce? (check at least one)

  • Bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2024 •
edited
Loading

🪓 PR closed, deleted preview at https://github.com/mml-io/avatar-tools/tree/gh-pages/pull/37/

@TheCodeTherapy TheCodeTherapy merged commit 7da3117 into main Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCodeTherapy TheCodeTherapy TheCodeTherapy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcusLongmuir @TheCodeTherapy