Avatar Converter CLI (#46) #47
Merged
+2,098
−1,202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🪓 PR closed, deleted preview at https://github.com/mml-io/avatar-tools/tree/gh-pages/pull/47/ |
TheCodeTherapy
previously approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46.
This PR adds a CLI version of the avatar converter tool that runs the correction steps as a NodeJS script rather than in a browser environment. Instructions for usage are added to the README.
The correction steps are now extracted into a shared package that is used by both the browser and CLI tools.
The running of THREEJS (specifically FBX and gLTF import/export) in NodeJS required polyfills for the canvas APIs amongst others that are used for texture operations.
What kind of change does your PR introduce? (check at least one)
Does your PR fulfill the following requirements?