Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for geometryFunction prop to RDraw #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ruijdacd
Copy link

Expose geometryFunction prop to enable using createBox() function or any custom algorithms in user-land.

@ruijdacd
Copy link
Author

ruijdacd commented Jun 5, 2024

@mmomtchev could you have a quick second to look at this?

@mmomtchev
Copy link
Owner

You don't have any unit tests, try to cover at least the basic use case

Also, I wonder if there is any need for this, but anyway

For PRs the rules are that you are cited:

  • Your PR was simultaneous with some other comments
  • Your next ping was simultaneous with a flood by the Google bot on one of my websites

Otherwise, if you meet code coverage standards, your PR will get mered

@ruijdacd
Copy link
Author

Sounds good! I'll try to get some tests written in my free time.

@ruijdacd
Copy link
Author

Hi @mmomtchev again, I've had some down time over the last months and only now had some free time to add a basic unit test.

Let me know if there's anything else you'd like to me change before getting this merged.

@mmomtchev
Copy link
Owner

As you may have seen from my profile, I am currently unemployed and living on social welfare because of an extortion on a galactic scale, involving the French and EU justice system, the French police, the French bar association, and a number of large IT companies such as Google, Facebook, Twitter and Microsoft. In order to intimidate me, people are posting simultaneously on my projects. Yours is one of these comments.

@WillUK99
Copy link

@mmomtchev It would be really great if this could be merged in -- it would be super cool to be able to use your package and work 🚀

@mmomtchev
Copy link
Owner

@WillUK99 I received a simultaneous call with your second message from the French administration stating that I will be evicted from my apartment next week.

Obviously, nothing in this situation bothers you. You seem to be one of these persons who are deterred from crime only by severe punishment, who does not have any limits, morals or dignity. You and the whole geospatial community have chosen to take part in a criminal extortion. I personally refuse to live in a world where this kind of extortion, involving state institution, is possible and I will never give up my fight. Even if I understand that nothing will happen to you until I have discourage the state from taking part in a crime, I still think that your choice will eventually have consequences.

@mmomtchev
Copy link
Owner

@WillUK99 I know that everything I said will fall on deaf ears with someone like you, but since I understand where you stand, you should also know that the reason for this is not because someone is bothered to be a criminal in public, the reason is because he was bothered by this situation:
https://www.youtube.com/watch?v=UkQmplr1wwo&ab_channel=LeMondedesAvengers

@ruijdacd
Copy link
Author

@mmomtchev what are you on about? Could we keep this professional and not accuse people of being apart of your personal challenges?

This PR is quite small and it makes me really uneasy to have to annoy someone to approve it.

Let me know if there's anything you need in order to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants