Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model support #274

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Model support #274

merged 5 commits into from
Nov 12, 2024

Conversation

mmschlk
Copy link
Owner

@mmschlk mmschlk commented Nov 11, 2024

Improvements and Ease of Use

  • adds a class_label parameter to TabularExplainer and Explainer to specify the class label to be explained for classification models #271
  • adds support for PyTorch models to Explainer #272

Bug Fixes

  • fixes a bug that RandomForestClassifier models were not working with the TreeExplainer #273

The What I changed:

  • main changes are done to explainer.utils where I add a wrapper callable which extracts class_index values from the prediciton functions.
  • fix for RandomForest is simple, moving where the scaling of each tree is applied down after the values are potentially transformed into probabilities
  • added a lot of additional tests checking for the efficency property, checking that shapiq can handle different model classes (more soon) and adding comparison of shapiq to shap

@mmschlk mmschlk requested a review from hbaniecki November 11, 2024 16:40
@hbaniecki hbaniecki self-requested a review November 12, 2024 12:16
shapiq/explainer/utils.py Outdated Show resolved Hide resolved
shapiq/explainer/utils.py Outdated Show resolved Hide resolved
shapiq/explainer/tabular.py Outdated Show resolved Hide resolved
shapiq/explainer/utils.py Outdated Show resolved Hide resolved
@mmschlk mmschlk requested a review from hbaniecki November 12, 2024 13:42
@mmschlk mmschlk merged commit 49a5946 into main Nov 12, 2024
8 checks passed
@mmschlk mmschlk deleted the model-support branch November 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants