Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning for Parser.php #31

Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix: warning for Parser.php #31

merged 3 commits into from
Jan 29, 2025

Conversation

clemblanco
Copy link
Contributor

Silencing a warning from PHP

WARN Mni\FrontYAML\Parser::__construct(): Implicitly marking parameter $yamlParser as nullable is deprecated, the explicit nullable type must be used instead...

image

Silencing a warning from PHP

> WARN  Mni\FrontYAML\Parser::__construct(): Implicitly marking parameter $yamlParser as nullable is deprecated, the explicit nullable type must be used instead...
src/Parser.php Outdated Show resolved Hide resolved
@mnapoli
Copy link
Owner

mnapoli commented Jan 28, 2025

Thanks! Added a minor comment and then we can merge 👍

@clemblanco
Copy link
Contributor Author

Thanks! Added a minor comment and then we can merge 👍

Sure thing 👌

@mnapoli mnapoli merged commit 06e43e7 into mnapoli:master Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants