Fix panic, use standard errors package and return more errors. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere was an error, then res.Body is nil so calling Close panics.
…turned, it can be compared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was using the library for a simple automated update tool and I got a panic when my network failed! It was due to a defer being placed before an error check had been made. I've corrected that (
6d9da4a), and also tidied a few things up:
Return errors returned by ioutil.ReadAll -- fb33db4, 6d9da4a
Use standard errors package for error -- c6b684f
Use md5.Sum (it's tidier) -- 19e52cd
Return errors from url.Parse -- c380603
Thanks,
Jacob