Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example to extract time courses with labels from custom atlas #12618

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Shrecki
Copy link

@Shrecki Shrecki commented May 17, 2024

What does this implement/fix?

An example on how to extract time courses of source reconstructed data when using a custom parcellation atlas!
On suggestion by @mscheltienne

Additional information

None, really.

Copy link

welcome bot commented May 17, 2024

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

Copy link
Member

@mscheltienne mscheltienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank 😄 ping me when you want a review, a couple of small points for now:

  • Title should have as many = under and above as characters in the title
  • You can check the rendered docs in the Check the render docs workflow, for now here.
  • Prefer pathlib.Path over os.path.join() to handle file/folder paths
  • Add a changelog entry by adding a file to this folder.
  • This is raised at the moment:
FileNotFoundError: MRI image does not exist: "/home/circleci/mne_data/MNE-sample-data/subjects/sample/mri/yeo_atlasaseg.mgz"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants