Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump lamassu, x2gbfs, ipl-dagster-pipeline #337

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hbruch
Copy link
Collaborator

@hbruch hbruch commented Mar 3, 2025

This PR contains the following changes:

@hbruch hbruch marked this pull request as draft March 3, 2025 13:42
@hbruch hbruch force-pushed the chore/update-2025-03-03 branch from 515dc72 to 544df64 Compare March 3, 2025 14:55
Copy link
Member

@derhuerst derhuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks:

  • Let's use permalinks when linking to external resources.
  • The x2gbfs changelog has the wrong year.
  • The x2gbfs Compose service's command should use quotes around the templated URL.

## [Unreleased]

### Changed

- GeoServer: fix image name in `.env` (`geoserver` -> `ipl-geoserver`), pulling the image should now be possible again
- GeoServer: hard-code platform `linux/amd64` because there are currently no other platforms supported
- `lamassu`: upgraded [`lamassu`](https://github.com/entur/lamassu) to [2025-03-01T04-51](https://hub.docker.com/layers/entur/lamassu/2025-03-01T04-51/images/sha256-742f539b77ded7173da2e5b66db922e8cd657d344531417de7e86cd5591fd7d5). This i.e. includes an internal refactoring which reduces redis memory usage and improves graphql performance. For details see https://github.com/entur/lamassu/blob/master/Changelog.md?plain=1#L9C64-L17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use permalinks when linking to external resources (like other projects' changelogs).

Suggested change
- `lamassu`: upgraded [`lamassu`](https://github.com/entur/lamassu) to [2025-03-01T04-51](https://hub.docker.com/layers/entur/lamassu/2025-03-01T04-51/images/sha256-742f539b77ded7173da2e5b66db922e8cd657d344531417de7e86cd5591fd7d5). This i.e. includes an internal refactoring which reduces redis memory usage and improves graphql performance. For details see https://github.com/entur/lamassu/blob/master/Changelog.md?plain=1#L9C64-L17
- `lamassu`: upgraded [`lamassu`](https://github.com/entur/lamassu) to [2025-03-01T04-51](https://hub.docker.com/layers/entur/lamassu/2025-03-01T04-51/images/sha256-742f539b77ded7173da2e5b66db922e8cd657d344531417de7e86cd5591fd7d5). This i.e. includes an internal refactoring which reduces redis memory usage and improves graphql performance. For details see [the Lamassu changelog](https://github.com/entur/lamassu/blob/bea6f73b88b1fd2816aab06efaf22ceca8230a30/Changelog.md#L9C64-L17).

## [Unreleased]

### Changed

- GeoServer: fix image name in `.env` (`geoserver` -> `ipl-geoserver`), pulling the image should now be possible again
- GeoServer: hard-code platform `linux/amd64` because there are currently no other platforms supported
- `lamassu`: upgraded [`lamassu`](https://github.com/entur/lamassu) to [2025-03-01T04-51](https://hub.docker.com/layers/entur/lamassu/2025-03-01T04-51/images/sha256-742f539b77ded7173da2e5b66db922e8cd657d344531417de7e86cd5591fd7d5). This i.e. includes an internal refactoring which reduces redis memory usage and improves graphql performance. For details see https://github.com/entur/lamassu/blob/master/Changelog.md?plain=1#L9C64-L17
- [dagster-pipeline/dagster-daemon/dagster-dagit: upgrade to `2025-03-03t11-50`](https://github.com/mobidata-bw/ipl-dagster-pipeline/blob/main/CHANGELOG.md?plain=1#L6-L10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [dagster-pipeline/dagster-daemon/dagster-dagit: upgrade to `2025-03-03t11-50`](https://github.com/mobidata-bw/ipl-dagster-pipeline/blob/main/CHANGELOG.md?plain=1#L6-L10)
- [dagster-pipeline/dagster-daemon/dagster-dagit: upgrade to `2025-03-03t11-50`](https://github.com/mobidata-bw/ipl-dagster-pipeline/blob/108a827949f41e9b94b0578169b3a20d6c484917/CHANGELOG.md#L6-L10)

## [Unreleased]

### Changed

- GeoServer: fix image name in `.env` (`geoserver` -> `ipl-geoserver`), pulling the image should now be possible again
- GeoServer: hard-code platform `linux/amd64` because there are currently no other platforms supported
- `lamassu`: upgraded [`lamassu`](https://github.com/entur/lamassu) to [2025-03-01T04-51](https://hub.docker.com/layers/entur/lamassu/2025-03-01T04-51/images/sha256-742f539b77ded7173da2e5b66db922e8cd657d344531417de7e86cd5591fd7d5). This i.e. includes an internal refactoring which reduces redis memory usage and improves graphql performance. For details see https://github.com/entur/lamassu/blob/master/Changelog.md?plain=1#L9C64-L17
- [dagster-pipeline/dagster-daemon/dagster-dagit: upgrade to `2025-03-03t11-50`](https://github.com/mobidata-bw/ipl-dagster-pipeline/blob/main/CHANGELOG.md?plain=1#L6-L10)
- [x2gbfs 2025-03-03T13-17:](https://github.com/mobidata-bw/x2gbfs/blob/main/CHANGELOG.md#2024-03-03)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ The year in the changelog is 2024 instead of 2025.

Suggested change
- [x2gbfs 2025-03-03T13-17:](https://github.com/mobidata-bw/x2gbfs/blob/main/CHANGELOG.md#2024-03-03)
- [x2gbfs 2025-03-03T13-17:](https://github.com/mobidata-bw/x2gbfs/blob/da35474fc4b0997549a67a746a3fc64cb9069af8/CHANGELOG.md#2024-03-03)

- [x2gbfs 2025-03-03T13-17:](https://github.com/mobidata-bw/x2gbfs/blob/main/CHANGELOG.md#2024-03-03)
- fix: update `deer` pricing plans
- round vehicle and station coords to at most six decimal places
- some x2gbfs deployment related changes, see x2gbfs [CHANGELOG]((https://github.com/mobidata-bw/x2gbfs/blob/main/CHANGELOG.md#2024-03-03)) for these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- some x2gbfs deployment related changes, see x2gbfs [CHANGELOG]((https://github.com/mobidata-bw/x2gbfs/blob/main/CHANGELOG.md#2024-03-03)) for these
- some x2gbfs deployment related changes, see x2gbfs [CHANGELOG](https://github.com/mobidata-bw/x2gbfs/blob/da35474fc4b0997549a67a746a3fc64cb9069af8/CHANGELOG.md#2024-03-03) for these

@@ -175,7 +175,7 @@ services:
volumes:
- ./var/gbfs/feeds:/app/out/
- ./var/gbfs/temp:/app/temp/
command: -p ${X2GBFS_PROVIDERS:?missing/empty} -b file:///var/gbfs/feeds -i ${X2GBFS_UPDATE_INTERVAL_SECONDS:?missing/empty}
command: -p ${X2GBFS_PROVIDERS:?missing/empty} -b file:///var/gbfs/feeds -c ${X2GBFS_CUSTOM_BASE_URL?missing/empty} -i ${X2GBFS_UPDATE_INTERVAL_SECONDS:?missing/empty}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
command: -p ${X2GBFS_PROVIDERS:?missing/empty} -b file:///var/gbfs/feeds -c ${X2GBFS_CUSTOM_BASE_URL?missing/empty} -i ${X2GBFS_UPDATE_INTERVAL_SECONDS:?missing/empty}
command: -p ${X2GBFS_PROVIDERS:?missing/empty} -b file:///var/gbfs/feeds -c '${X2GBFS_CUSTOM_BASE_URL?missing/empty}' -i ${X2GBFS_UPDATE_INTERVAL_SECONDS:?missing/empty}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants