fix: add waitToSettleTimeOut on swipe commands #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelniklasson
approved these changes
Nov 26, 2024
amanjeetsingh150
force-pushed
the
add-waitToTimeOut
branch
from
57e7a72 to
54a26d3
Compare
|
Created issue for this: |
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding
waitToSettleTimeoutMsto the swipe commands that do waitForAppToSettle call. This is to control the wait time if there are repeatable animations on the screen.Using this option would help users to wait less on the screens where app is settled but have repeatable animations.
Testing
Issues fixed