Enable running Maestro on Windows without WSL #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Leland-Takamine
commented
Jan 14, 2025
Leland-Takamine
commented
- Pulls in Dadb fixes for Windows: Fixing Dadb for Windows dadb#81
- Updates classpath to use globs in order to avoid "input line it too long"
amanjeetsingh150
approved these changes
Jan 15, 2025
Fishbowler
requested changes
Jan 15, 2025
maestro-cli/src/main/java/maestro/cli/runner/resultview/AnsiResultView.kt
Outdated
Show resolved
Hide resolved
Leland-Takamine
force-pushed
the
fix-windows
branch
from
4b7f0f9 to
1fffe6a
Compare
Fishbowler
approved these changes
Jan 16, 2025
luistak
pushed a commit
that referenced
this pull request
Jan 24, 2025
* Fix Windows script error by making classpath shorting using globs * Update dadb * Do not use emojis on Windows * Fix Studio npm builds on Windows * Make OS comparison case-insensitive * Use smiley face instead of check * Use + instead of special char * Remove debug condition --------- Co-authored-by: Dan Caseley <[email protected]>
luistak
added a commit
that referenced
this pull request
Jan 29, 2025
* feat: Adds Insights Notification Allows users to disable insights notification based on the new Environment Variable * feat(analyze): Adds initial Analyze option to test command locally * refactor(analyze): Test analyze report and generation to use server side output * feat(login): Adjusts apiUrl option to kebab case * feat(test): Adjusts api url and key options to kebab case * style(analyze): Adjusts cli output messages and styles * Scroll local video rendering to follow currently executing command (#2232) * Update README.md * Web fixes (#2250) * Select web when platform is specified * Do not log errors on device screen endpoint since this floods the terminal with unnecessary noise when killing studio * Add url input in studio for web * Handle openLink without scheme * Remove comment * Revert unnecessary change * Remove unused import * Enable running Maestro on Windows without WSL (#2248) * Fix Windows script error by making classpath shorting using globs * Update dadb * Do not use emojis on Windows * Fix Studio npm builds on Windows * Make OS comparison case-insensitive * Use smiley face instead of check * Use + instead of special char * Remove debug condition --------- Co-authored-by: Dan Caseley <[email protected]> * Add console.log messages directly to the maestro log (#2249) * Fix: dark mode for browser action bar (#2255) * Prepare release 1.39.9 (#2245) * Improved install script (#2263) * Remove unused variable in install script * Remove previous files when installing maestro-cli * Prepare for release 1.39.10 (#2264) * feat(analyze): Adds initial Analyze option to test command locally * refactor(analyze): Test analyze report and generation to use server side output * feat(login): Adjusts apiUrl option to kebab case * feat(test): Adjusts api url and key options to kebab case * style(analyze): Adjusts cli output messages and styles * feat(analyze): Adjusts Analysis Manager to maybe notify new feature * fix(analyze): Simplify AnalyzeResponse contract * refactor(analyze): Rename Flow Files to Debug files along with non-primitive usage of debug files * fix(analyze): Adjusts Analytics class to Notification * feat(analyze): Filters similar screenshots to avoid noise and unnecessary data * fix(analyze): Tryout typo adjustmentt * fix(analyze): Adjusts notification var naming --------- Co-authored-by: Leland Takamine <[email protected]> Co-authored-by: Dan Caseley <[email protected]> Co-authored-by: Dmitry Zaytsev <[email protected]> Co-authored-by: Amanjeet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.