Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analyze): Adds Analyze option to test command #2265

Merged
merged 28 commits into from
Jan 29, 2025
Merged

Conversation

luistak
Copy link
Contributor

@luistak luistak commented Jan 22, 2025

Proposed changes

This PR:

  • Adds new --analyze flag to optionally generate AI insights analysis after the test command
  • Adds a new notification to new users about the Analyze feature
  • Adds new debug parameters for Login Command

Testing

  • Local

Issues fixed

@luistak luistak marked this pull request as ready for review January 22, 2025 12:51
luistak and others added 17 commits January 23, 2025 10:05
* Select web when platform is specified

* Do not log errors on device screen endpoint since this floods the terminal with unnecessary noise when killing studio

* Add url input in studio for web

* Handle openLink without scheme

* Remove comment

* Revert unnecessary change

* Remove unused import
* Fix Windows script error by making classpath shorting using globs

* Update dadb

* Do not use emojis on Windows

* Fix Studio npm builds on Windows

* Make OS comparison case-insensitive

* Use smiley face instead of check

* Use + instead of special char

* Remove debug condition

---------

Co-authored-by: Dan Caseley <[email protected]>
* Remove unused variable in install script

* Remove previous files when installing maestro-cli
@luistak luistak force-pushed the feat/insights-analyze branch from 2546cc3 to c8e4f5f Compare January 24, 2025 12:33
Copy link
Collaborator

@amanjeetsingh150 amanjeetsingh150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A potential improvement you can do for cleaning the similar screenshots would be to use this logic from maestro:

https://github.com/mobile-dev-inc/maestro/blob/f69bf5b7997b974195b5af7dc555741eb13ab6bb/maestro-client/src/main/java/maestro/utils/ScreenshotUtils.kt#L86

We can only send the screenshots which are considerably different from each other.

Copy link
Collaborator

@amanjeetsingh150 amanjeetsingh150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you also add the command change that we add with this on maestro cli?

@luistak luistak requested a review from herval January 28, 2025 17:23
@luistak luistak merged commit a6d0e57 into main Jan 29, 2025
8 checks passed
@luistak luistak deleted the feat/insights-analyze branch January 29, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants