-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analyze): Adds Analyze option to test command #2265
Conversation
Allows users to disable insights notification based on the new Environment Variable
* Select web when platform is specified * Do not log errors on device screen endpoint since this floods the terminal with unnecessary noise when killing studio * Add url input in studio for web * Handle openLink without scheme * Remove comment * Revert unnecessary change * Remove unused import
* Fix Windows script error by making classpath shorting using globs * Update dadb * Do not use emojis on Windows * Fix Studio npm builds on Windows * Make OS comparison case-insensitive * Use smiley face instead of check * Use + instead of special char * Remove debug condition --------- Co-authored-by: Dan Caseley <[email protected]>
* Remove unused variable in install script * Remove previous files when installing maestro-cli
2546cc3
to
c8e4f5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A potential improvement you can do for cleaning the similar screenshots would be to use this logic from maestro:
We can only send the screenshots which are considerably different from each other.
maestro-cli/src/main/java/maestro/cli/insights/TestAnalysisManager.kt
Outdated
Show resolved
Hide resolved
maestro-cli/src/main/java/maestro/cli/insights/TestAnalysisManager.kt
Outdated
Show resolved
Hide resolved
maestro-cli/src/main/java/maestro/cli/insights/TestAnalysisManager.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can you also add the command change that we add with this on maestro cli?
…imitive usage of debug files
Proposed changes
This PR:
--analyze
flag to optionally generate AI insights analysis after the test commandTesting
Issues fixed