Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e race condition in scrollUntilVisible timeout test #2274

Merged
merged 1 commit into from
Jan 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: e2e race condition in scrollUntilVisible timeout test
Fishbowler committed Jan 28, 2025
commit e6b7b172016340589a7a543327d7dec53d3366dd
2 changes: 1 addition & 1 deletion e2e/workspaces/demo_app/scrollUntilVisible_timeout.yaml
Original file line number Diff line number Diff line change
@@ -10,4 +10,4 @@ tags:
timeout: 1000
optional: true
- evalScript: ${maestro.endTime = new Date()}
- assertTrue: ${maestro.endTime - maestro.startTime < 5000} # Far less than the 20000 default, but enough to allow for processing time
- assertTrue: ${maestro.endTime - maestro.startTime < 12000} # Far less than the 20000 default, but enough to allow for processing time