Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openLink documentation #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tokou
Copy link

@tokou tokou commented Sep 16, 2024

It's probably too verbose and has too many images but I'll let you edit it to your linking.

Linked #87

Linked mobile-dev-inc/Maestro#1999 (comment)

Copy link
Collaborator

@Fishbowler Fishbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I've added a few minor nitpicks.

@@ -8,9 +8,15 @@ To open a link on a device (i.e. a deep link):

### Auto verification of your Android Apps 
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Auto verification of your Android Apps 
### Auto verification of your Android Apps


If not, the behavior would depend on the Android version of the device.

Starting from Android 12, such apps needs for the user to manually verify the association of the app with the domains through the "Open by default" settings menu.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Starting from Android 12, such apps needs for the user to manually verify the association of the app with the domains through the "Open by default" settings menu.
Starting from Android 12, such apps need the user to manually verify the association of the app with the domains through the "Open by default" settings menu.

Comment on lines +53 to +56

| Accept | Sign in | Sync | Notifications | Ad privacy | Other ad privacy |
|-----------------------------------------------------------------------------------------------------------|--------------------------------------------------------------|-------------------------------------------------------------------------------------------------|------------------------------------------------------------------|----------------------------------------------------|--------------------------------------------------|
| ![chrome_welcome_accept](https://github.com/user-attachments/assets/95a899f7-a375-455c-91ff-e15e2cbf6c79) | ![chrome_welcome_account](../../.gitbook/assets/account.png) | ![chrome_sync](https://github.com/user-attachments/assets/8e790d27-fe89-470d-a28b-1bda8853f59d) | ![chrome_notifications](../../.gitbook/assets/notifications.png) | ![ad_privacy](../../.gitbook/assets/adprivacy.png) | ![ad_privacy](../../.gitbook/assets/otherad.png) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that these demonstrations are necessary. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants