Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added log for null hierarchy #2217

Merged
merged 4 commits into from
Dec 29, 2024
Merged

chore: added log for null hierarchy #2217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f006d3
chore: added log for null hierarchy
proksh Dec 24, 2024
77742ce
chore: added log for view hierarchy
proksh Dec 24, 2024
f2e2311
updated logs
proksh Dec 27, 2024
0fa0014
fix errors
proksh Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions maestro-ios-driver/src/main/kotlin/xcuitest/XCTestDriverClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ class XCTestDriverClient(
pathString: String,
responseBodyAsString: String,
): String {
logger.warn("Status code: $code, body: $responseBodyAsString");
val error = mapper.readValue(responseBodyAsString, Error::class.java)
when {
code in 400..499 -> {
Expand Down
6 changes: 6 additions & 0 deletions ...ro-ios-xctest-runner/maestro-driver-iosUITests/Routes/Handlers/ViewHierarchyHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ struct ViewHierarchyHandler: HTTPHandler {
let body = try JSONEncoder().encode(viewHierarchy)
return HTTPResponse(statusCode: .ok, body: body)
} catch let error as AppError {
logger.error("AppError in handleRequest, Error:\(error)");
return error.httpResponse
} catch let error {
logger.error("Error in handleRequest, Error:\(error)");
return AppError(message: "Snapshot failure while getting view hierarchy. Error: \(error.localizedDescription)").httpResponse
}
}
Expand Down Expand Up @@ -80,8 +82,12 @@ struct ViewHierarchyHandler: HTTPHandler {
}

func getHierarchyWithFallback(_ element: XCUIElement) throws -> AXElement {
logger.info("Starting getHierarchyWithFallback for element: \(element.debugDescription)")

do {
var hierarchy = try elementHierarchy(xcuiElement: element)
logger.info("Successfully retrieved element hierarchy. Depth: \(hierarchy.depth())")

if hierarchy.depth() < snapshotMaxDepth {
return hierarchy
}
Expand Down
Loading