Revert keyboard change that throws error if keyboard is not shown #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 9165c50.
|
Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change |
Fishbowler
approved these changes
Dec 30, 2024
Fishbowler
approved these changes
Dec 30, 2024
amanjeetsingh150
force-pushed
the
revert-keyboard-change
branch
from
8cf86e5 to
500b8a9
Compare
amanjeetsingh150
force-pushed
the
revert-keyboard-change
branch
from
500b8a9 to
4639606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Let's enable this when we have better way to detect active element. Right now there are cases for input text even without a keyboard.
Testing
Issues fixed