Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portability: restore check for system OpenSSL libraries #1240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cgull
Copy link
Member

@cgull cgull commented Nov 15, 2022

Some non-Linux systems, most notably FreeBSD and the other *BSDs, have OpenSSL as part of the base OS. FreeBSD, at least, does not have a pkg-config .pc file, because it's not actually a package. (All the *BSDs also have various OpenSSL versions and its forks available in packages as well. But using them can cause various kinds of pain dealing with multiple versions, and it's better to avoid them if they're not needed.)

There was a check using AX_CHECK_LIBRARY() that got lost in commit bacc024. This brings it back, and also removes extended GNU Make syntax that I accidentally put in src/include/Makefile.ac that OpenBSD make refused to put up with.

FreeBSD, OpenBSD, and I think NetBSD all have OpenSSL as part of the
base OS.  Since they are not packages they don't have .pc files and
won't be detected by PKG_CHECK_MODULES().

Restore the explicit detection of these system libraries lost in
commit bacc024.
@achernya
Copy link
Collaborator

I believe the removal of this AX_CHECK_LIBRARy was intentional. @bbarenblat can you please take a look?

@cgull
Copy link
Member Author

cgull commented Nov 17, 2022

@bbarenblat any comment? We can make that check more specific to avoid what I'm guessing is some Linux or OpenSSL-variant related issue you have with it.

@bbarenblat
Copy link
Contributor

Hey, folks, sorry for the delay. I’m pretty sure I removed that AX_CHECK_LIBRARY simply because I didn’t understand why it was necessary. BSD portability makes total sense. Can you add a configure.ac comment to the effect that PKG_CHECK_MODULES is insufficient because BSD systems ship libcrypto.so without a pkg-config file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants