Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed property key attribution in generic createSimpleSchema<T> #186

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jglanz
Copy link
Contributor

@jglanz jglanz commented Oct 11, 2024

While using createSimpleSchema<T> I had noticed that key/property validation wasn't working and had a peek at the typings.

I noticed that while T was accepted as a generic, it was not used with regard to the property mappings provided, so a 3 character change was made :)

@mweststrate
Copy link
Member

Thanks for catching!

@mweststrate mweststrate merged commit fb544bb into mobxjs:master Oct 14, 2024
4 checks passed
@coveralls
Copy link

Coverage Status

coverage: 90.239%. remained the same
when pulling c0c1011 on jglanz:master
into f8b9196 on mobxjs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants