Lint.

mockingbirdnest · Jan 10, 2024 · 6582420 · 6582420
1 parent 00fc37c
commit 6582420
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/numerics/fixed_arrays_body.hpp b/numerics/fixed_arrays_body.hpp
@@ -202,7 +202,7 @@ Product<Scalar, Product<LScalar, RScalar>>
 FixedMatrix<Scalar, rows_, columns_>::operator()(
     FixedVector<LScalar, columns_> const& left,
     FixedVector<RScalar, rows_> const& right) const {
-  return TransposedView{left} * (*this * right);
+  return TransposedView{left} * (*this * right);  // NOLINT
 }
 
 template<typename Scalar, int rows_, int columns_>

diff --git a/numerics/fixed_arrays_test.cpp b/numerics/fixed_arrays_test.cpp
@@ -86,7 +86,7 @@ TEST_F(FixedArraysTest, Assignment) {
 }
 
 TEST_F(FixedArraysTest, Norm) {
-  EXPECT_EQ(35, TransposedView{v4_} * v4_);
+  EXPECT_EQ(35, TransposedView{v4_} * v4_);  // NOLINT
   EXPECT_EQ(Sqrt(35.0), v4_.Norm());
   EXPECT_EQ(35, v4_.Norm²());
   EXPECT_EQ(Sqrt(517.0), m34_.FrobeniusNorm());
@@ -121,7 +121,7 @@ TEST_F(FixedArraysTest, VectorSpaces) {
 }
 
 TEST_F(FixedArraysTest, Algebra) {
-  EXPECT_EQ(-535, TransposedView{u3_} * v3_);
+  EXPECT_EQ(-535, TransposedView{u3_} * v3_);  // NOLINT
   EXPECT_EQ((FixedMatrix<double, 3, 4>({-30, -30,  10,   40,
                                         -93, -93,  31,  124,
                                         141, 141, -47, -188})),

diff --git a/numerics/matrix_computations_body.hpp b/numerics/matrix_computations_body.hpp
@@ -924,7 +924,7 @@ template<typename Matrix, typename Vector>
 typename RayleighQuotientGenerator<Matrix, Vector>::Result
 RayleighQuotient(Matrix const& A, Vector const& x) {
   // [GV13], section 8.2.3.
-  return TransposedView{x} * (A * x) / (TransposedView{x} * x);
+  return TransposedView{x} * (A * x) / (TransposedView{x} * x);  // NOLINT
 }
 
 template<typename Matrix, typename Vector>

diff --git a/numerics/unbounded_arrays.hpp b/numerics/unbounded_arrays.hpp
@@ -3,6 +3,7 @@
 #include <initializer_list>
 #include <memory>
 #include <type_traits>
+#include <utility>
 #include <vector>
 
 #include "base/tags.hpp"
@@ -369,6 +370,7 @@ UnboundedVector<Product<LScalar, RScalar>> operator*(
     UnboundedVector<RScalar> const& right);
 
 // Use this operator to multiply a row vector with a matrix.  We don't have an
+// operator returning a TransposedView as that would cause dangling references.
 template<typename LScalar, typename RScalar>
 UnboundedVector<Product<LScalar, RScalar>> operator*(
     TransposedView<UnboundedMatrix<LScalar>> const& left,

diff --git a/numerics/unbounded_arrays_body.hpp b/numerics/unbounded_arrays_body.hpp
@@ -218,7 +218,7 @@ Product<Scalar, Product<LScalar, RScalar>>
 UnboundedMatrix<Scalar>::operator()(
     UnboundedVector<LScalar> const& left,
     UnboundedVector<RScalar> const& right) const {
-  return TransposedView{left} * (*this * right);
+  return TransposedView{left} * (*this * right);  // NOLINT
 }
 
 template<typename Scalar>
@@ -505,7 +505,7 @@ UnboundedUpperTriangularMatrix<Scalar>::Transpose(
 template<typename LScalar, typename RScalar>
 Product<LScalar, RScalar> InnerProduct(UnboundedVector<LScalar> const& left,
                                        UnboundedVector<RScalar> const& right) {
-  return TransposedView{left} * right;
+  return TransposedView{left} * right;  // NOLINT
 }
 
 template<typename Scalar>

diff --git a/numerics/unbounded_arrays_test.cpp b/numerics/unbounded_arrays_test.cpp
@@ -95,7 +95,7 @@ TEST_F(UnboundedArraysTest, Assignment) {
 }
 
 TEST_F(UnboundedArraysTest, Norm) {
-  EXPECT_EQ(35, TransposedView{v4_} * v4_);
+  EXPECT_EQ(35, TransposedView{v4_} * v4_);  // NOLINT
   EXPECT_EQ(Sqrt(35.0), v4_.Norm());
   EXPECT_EQ(Sqrt(4'126'647.0), m4_.FrobeniusNorm());
 }
@@ -111,7 +111,7 @@ TEST_F(UnboundedArraysTest, MultiplicationDivision) {
 }
 
 TEST_F(UnboundedArraysTest, Algebra) {
-  EXPECT_EQ(3270, TransposedView{v3_} * v3_);
+  EXPECT_EQ(3270, TransposedView{v3_} * v3_);  // NOLINT
 }
 
 TEST_F(UnboundedArraysTest, VectorIndexing) {