Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the terrain altitude at the right place to determine whether the periapsis is underground #3832

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jan 1, 2024

Possibly fix #3826. The preconditions on ComputeCollision are a bit of a mess, but so long as we are underground at last_time it should work. However, we were instead checking whether we would have been underground had we been on one branch of the φ=λ analemma. The height above terrain calculation used to actually compute the collision was correct, which is why it would show up in the right place (up to the issue of multiple intersections). This may explain some oddities as to whether we would try to compute the collision at all—though the underground periapsis thing is of course fundamentally deficient as a criterion.

@pleroy pleroy added the LGTM label Jan 1, 2024
@eggrobin eggrobin merged commit ff7f1aa into mockingbirdnest:master Jan 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants