Only load Skopos in career games #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In sandbox saves, there's no instance of `ContractSystem`. This causes a NRE to be thrown from `Network.UpdateConnections()` in every FixedUpdate. With this change, Skopos doesn't get loaded in Sandbox or Science mode save files: they don't have contracts, so Skopos wouldn't do anything anyways. Fixes mockingbirdnest#8
eggrobin
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sandbox saves, there's no instance of
ContractSystem. This causes a NRE to be thrown fromNetwork.UpdateConnections()in every FixedUpdate.With this change, Skopos doesn't get loaded in Sandbox or Science mode save files: they don't have contracts, so Skopos wouldn't do anything anyways.
Fixes #8