Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ModelicaTest/Media/TestOnly/R134a_setState_pTX/MoistAir.csv #9

Closed
wants to merge 1 commit into from

Conversation

maltelenz
Copy link

This file is misplaced.

@beutlich
Copy link
Member

@maltelenz
Copy link
Author

I guess we need an additional PR for 4.0.0 if we want to fix that branch as well?

@beutlich
Copy link
Member

I guess we need an additional PR for 4.0.0 if we want to fix that branch as well?

Do not get it. If it is fixed in v4.0.0 and not touched by #8, it will be fine.

@maltelenz
Copy link
Author

Do not get it. If it is fixed in v4.0.0 and not touched by #8, it will be fine.

Really? There is already a https://github.com/modelica/MAP-LIB_ReferenceResults/tree/v4.1.0 branch. How would a PR against 4.0.0 fix it on the 4.1.0 branch?

@beutlich
Copy link
Member

beutlich commented Mar 27, 2024

Isn't v41.0.0 not branched off of v4.0.0? If yes, v4.1.0 can be rebased.

@maltelenz
Copy link
Author

v4.1.0 can be rebased.

I wasn't aware we were rebasing branches in this repository. In fact, I have no idea what workflow we are following in this repository...

@beutlich
Copy link
Member

OK, resolved in v4.0.0 by d6a2b9b.

@beutlich
Copy link
Member

beutlich commented Jun 5, 2024

If yes, v4.1.0 can be rebased.

Done.

@beutlich beutlich closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants