Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle units of literal constants by means of rules for the empty unit #3257

Open
wants to merge 26 commits into
base: MCP/0027
Choose a base branch
from
Open

Handle units of literal constants by means of rules for the empty unit #3257

wants to merge 26 commits into from

Commits on Oct 4, 2022

  1. Initial commit of ReadMe.md for MCP-0027

    @henrikt-ma
    henrikt-ma committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    7524b11 View commit details
    Browse the repository at this point in the history

  2. Handle units of literal constants by means of rules for the empty unit

    @henrikt-ma
    henrikt-ma committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    1309d10 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Clarify that all operands of additive operators need to have the same… 

    … unit
    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    2dfb4e8 View commit details
    Browse the repository at this point in the history

  2. Clarify "component references outside functions"

    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    0c62f41 View commit details
    Browse the repository at this point in the history

  3. Fix small mistake in example

    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    203c16e View commit details
    Browse the repository at this point in the history

  4. Change "common sense" -> "(standard) dimensional analysis"

    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    5d42065 View commit details
    Browse the repository at this point in the history

  5. Add section with examples of "standard dimensional analysis"

    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    fc4abde View commit details
    Browse the repository at this point in the history

  6. Fix minor typo

    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    b86567b View commit details
    Browse the repository at this point in the history

  7. Put quotes around 'standard dimensional analysis'

    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    1f5131c View commit details
    Browse the repository at this point in the history

  8. Say "multiplying the operands' units"

    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    3291a73 View commit details
    Browse the repository at this point in the history

  9. Make use of terminology 'dimensional homogenity'

    @henrikt-ma
    henrikt-ma committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    f639afc View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Don't present lists as "Examples of...", but add "other" item at the end 

    As suggested by @bilderbuchi.
    @henrikt-ma
    henrikt-ma committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    3a3b1f0 View commit details
    Browse the repository at this point in the history

  2. Say "reject or approve" 

    As suggested by @bilderbuchi.
    @henrikt-ma
    henrikt-ma committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e411347 View commit details
    Browse the repository at this point in the history

  3. Add missing "on"

    @henrikt-ma
    henrikt-ma committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    f3755a2 View commit details
    Browse the repository at this point in the history

  4. Reformulate "In some cases" 

    Trying to address comment by @bilderbuchi.
    @henrikt-ma
    henrikt-ma committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    fccda32 View commit details
    Browse the repository at this point in the history

  5. Change 'can be' -> 'is' 

    Trying to address comment by @bilderbuchi.
    @henrikt-ma
    henrikt-ma committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    89092ba View commit details
    Browse the repository at this point in the history

  6. Fix typo in comment

    @henrikt-ma
    henrikt-ma committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    82bb062 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Describe unit propagation and elaborate bottom-up nature of unit deri… 

    …vation
    @henrikt-ma
    henrikt-ma committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    99ff3c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Also describe unit mappings of transcendental functions to match othe… 

    …r proposal
    @henrikt-ma
    henrikt-ma committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    13529f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Change 'are expected to' -> 'should' 

    Ad discussed with @bilderbuchi.
    @henrikt-ma
    henrikt-ma committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    847e645 View commit details
    Browse the repository at this point in the history

  2. Add example illustrating bottom-up nature of unit inference

    @henrikt-ma
    henrikt-ma committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    ebfc229 View commit details
    Browse the repository at this point in the history

  3. Make stronger statement about when unit inference takes place

    @henrikt-ma
    henrikt-ma committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    232c4fa View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Change example on undefined unit to user-defined function instead of … 

    …'sin'
    @henrikt-ma
    henrikt-ma committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    9aeb15f View commit details
    Browse the repository at this point in the history

  2. Simplify proposal by not omitting rules concerning non-empty units

    @henrikt-ma
    henrikt-ma committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    a28b795 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Move 'Otherwise...' into item list 

    As suggested by @qlambert-pro.
    @henrikt-ma
    henrikt-ma committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    089f554 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Rule out unit inference for components with empty unit-attribute

    @henrikt-ma
    henrikt-ma committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    35e4f01 View commit details
    Browse the repository at this point in the history