Fix regex to optionally ignore quoted strings when checking for deprecated Text.lineColor annotation (CI) #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
approved these changes
Aug 17, 2023
HansOlsson
approved these changes
Aug 18, 2023
|
The "deprecation_checks" failed. This is due to presence of deprecated Text.lineColor annotation in
A corresponding PR #4181 fix this. Once that PR is merged, this PR can be rebased and all checks shall pass. |
Previously, a Text.lineColor annotation was not detected, if there was a closing parenthesis (within a quoted Text.textString annotation), e.g.
```
Text(extent={{-100,80},{-80,60}}, textString="1)", lineColor={0,0,255})
```
beutlich
force-pushed
the
fix-lineColor-regex
branch
from
8c0bf7d
to
fe0653b
Compare
tobolar
added a commit
to tobolar/PlanarMechanics
that referenced
this pull request
Sep 22, 2023
tobolar
added a commit
to dzimmer/PlanarMechanics
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a Text.lineColor annotation was not detected, if there was a closing parenthesis (within a quoted Text.textString annotation), e.g.
See #4181.