Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math asserts (#4344) #4470

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Math asserts (#4344) #4470

merged 1 commit into from
Oct 24, 2024

Conversation

Esther-Devakirubai
Copy link
Contributor

  • AddAssertsForDiff

  • AddAssertForIntegration

Backports #4344

@HansOlsson @Esther-Devakirubai
Math asserts (#4344)
e6bfd4b 
* AddAssertsForDiff

* AddAssertForIntegration
@Esther-Devakirubai Esther-Devakirubai added the L: Math Issue addresses Modelica.Math label Sep 30, 2024
@Esther-Devakirubai Esther-Devakirubai added this to the MSL4.1.0 milestone Sep 30, 2024
@Esther-Devakirubai Esther-Devakirubai mentioned this pull request Sep 30, 2024
Merged
casella
casella approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arunkumar-narasimhan
arunkumar-narasimhan approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@arunkumar-narasimhan arunkumar-narasimhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@beutlich beutlich added the example Issue only addresses example(s) label Oct 14, 2024
@Esther-Devakirubai
Copy link
Contributor Author

@casella Can you please help with this? Merging is blocked for us.

@casella casella merged commit 5114284 into maint/4.1.x Oct 24, 2024
6 checks passed
@casella casella deleted the backport_pr4344 branch October 24, 2024 15:27
@casella
Copy link
Contributor

casella commented Oct 24, 2024

Sure, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunkumar-narasimhan arunkumar-narasimhan arunkumar-narasimhan approved these changes

@casella casella casella approved these changes

Assignees
No one assigned
Labels
example Issue only addresses example(s) L: Math Issue addresses Modelica.Math
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Esther-Devakirubai @casella @arunkumar-narasimhan @beutlich @HansOlsson