Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSL 4.1.0 Regressions: set FundamentalWave..SymmetricPolyphaseWinding.ZeroInductor.i0 #4491

Merged
merged 3 commits into from
Oct 28, 2024
Merged

MSL 4.1.0 Regressions: set FundamentalWave..SymmetricPolyphaseWinding.ZeroInductor.i0 #4491

merged 3 commits into from
Oct 28, 2024

Conversation

beutlich
Copy link
Member

Backport of #4486 from master to maint/4.1.x.

@AHaumer @beutlich
MSL 4.1.0 Regressions: set FundamentalWave..SymmetricPolyphaseWinding…
3662661 
….ZeroInductor.i0(nominal=10) to avoid timeout during regression test
@AHaumer @beutlich
removed vendor-specific annotation
47f0895
@AHaumer @beutlich
moved the modifier zeroInductor.i0(nominal=10) from Modelica/Magnetic…
ffc7b5c 
…/FundamentalWave/BasicMachines/Components/SymmetricPolyphaseWinding 7to Modelica/Magnetic/FundamentalWave/Examples/BasicMachines/InductionMachines/IMC_YD
@beutlich beutlich added L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases) labels Oct 27, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Oct 27, 2024
@beutlich beutlich mentioned this pull request Oct 27, 2024
Merged
maltelenz
maltelenz approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this contains the changes it claims to backport.

@AHaumer AHaumer self-requested a review October 28, 2024 08:39
AHaumer
AHaumer approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the changes moving if to the next line and replacing 1e-4 by 0.0001 but it's ok.

@AHaumer AHaumer merged commit 72d5551 into modelica:maint/4.1.x Oct 28, 2024
6 checks passed
@beutlich beutlich deleted the backport-issue4486 branch October 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AHaumer AHaumer AHaumer approved these changes

@maltelenz maltelenz maltelenz approved these changes

Assignees
No one assigned
Labels
L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@beutlich @maltelenz @AHaumer