Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODELIX-667 Refactor MetaModelGenerator #392

Merged
merged 13 commits into from
Jan 16, 2024

Conversation

mhuster23
Copy link
Contributor

@mhuster23 mhuster23 commented Jan 5, 2024

Splits MetaModelGenerator into multiple smaller classes and methods, that are easier to digest.
Also introduces the runBuild method to make the builder pattern less distracting.

@mhuster23
Copy link
Contributor Author

mhuster23 commented Jan 5, 2024

generateModelQLFile will also be extracted into a separate file after #379 is merged.

@mhuster23 mhuster23 force-pushed the refactor/split-metamodel-generator branch from 9275798 to 435f3f0 Compare January 5, 2024 15:04
@mhuster23 mhuster23 force-pushed the refactor/split-metamodel-generator branch from 435f3f0 to 3d17206 Compare January 12, 2024 11:14
@mhuster23 mhuster23 force-pushed the refactor/split-metamodel-generator branch from 3d17206 to a1940fe Compare January 12, 2024 11:41
@mhuster23 mhuster23 marked this pull request as ready for review January 12, 2024 12:13
@mhuster23 mhuster23 requested a review from slisson as a code owner January 12, 2024 12:13
Copy link
Contributor

@languitar languitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial ideas inline.

@mhuster23 mhuster23 merged commit 2b733bb into main Jan 16, 2024
13 checks passed
@mhuster23 mhuster23 deleted the refactor/split-metamodel-generator branch January 16, 2024 12:44
@slisson
Copy link
Member

slisson commented Jan 17, 2024

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants