-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODELIX-667 Refactor MetaModelGenerator #392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mhuster23
force-pushed
the
refactor/split-metamodel-generator
branch
from
January 5, 2024 15:04
9275798
to
435f3f0
Compare
mhuster23
force-pushed
the
refactor/split-metamodel-generator
branch
from
January 12, 2024 11:14
435f3f0
to
3d17206
Compare
mhuster23
force-pushed
the
refactor/split-metamodel-generator
branch
from
January 12, 2024 11:41
3d17206
to
a1940fe
Compare
languitar
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial ideas inline.
model-api-gen/src/main/kotlin/org/modelix/metamodel/generator/EnumFileGenerator.kt
Outdated
Show resolved
Hide resolved
model-api-gen/src/main/kotlin/org/modelix/metamodel/generator/MetaModelGenerator.kt
Outdated
Show resolved
Hide resolved
model-api-gen/src/main/kotlin/org/modelix/metamodel/generator/LanguageFileGenerator.kt
Outdated
Show resolved
Hide resolved
model-api-gen/src/main/kotlin/org/modelix/metamodel/generator/ModelQLFileGenerator.kt
Outdated
Show resolved
Hide resolved
model-api-gen/src/main/kotlin/org/modelix/metamodel/generator/MetaModelGenerator.kt
Outdated
Show resolved
Hide resolved
model-api-gen/src/main/kotlin/org/modelix/metamodel/generator/NameConfigBasedGenerator.kt
Outdated
Show resolved
Hide resolved
languitar
approved these changes
Jan 16, 2024
🎉 This PR is included in version 4.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits
MetaModelGenerator
into multiple smaller classes and methods, that are easier to digest.Also introduces the
runBuild
method to make the builder pattern less distracting.