Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instances manager #233

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Draft

Fix instances manager #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16dccad
fix: NPE during closing of websocket connections
slisson Dec 20, 2024
ea1741a
fix: debug port on instances-manager wasn't open
slisson Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instances-manager/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ WORKDIR /instances-manager/
EXPOSE 33332

COPY build/install/instances-manager/ /instances-manager/
ENV instances_MANAGER_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 -XX:MaxRAMPercentage=85"
ENV INSTANCES_MANAGER_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 -XX:MaxRAMPercentage=85"
CMD ["/instances-manager/bin/instances-manager"]
2 changes: 1 addition & 1 deletion ...-manager/src/main/kotlin/org/modelix/instancesmanager/ProxyServletWithWebsocketSupport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ abstract class ProxyServletWithWebsocketSupport : ProxyServlet() {
}
}

override fun onWebSocketClose(statusCode: Int, reason: String) {
override fun onWebSocketClose(statusCode: Int, reason: String?) {
sessionA?.close(statusCode, reason)
}

Expand Down
Loading