fix message merging strategy when multi-turn tool calling. #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leoyzen
force-pushed
the
feature/multi-turn-tool-message-joining
branch
from
d682b63 to
3de20f6
Compare
|
@tastelikefeet Please give a review of this pr. |
hjh0119
approved these changes
Jan 27, 2025
tastelikefeet
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
修复 #2984 问题。多轮 tool-calling 时，message 会将
role=tool内容merge 进上一条role=assistant的内容中；但是连续的 tool calling 会导致消息列表会由user→assistant→tool→assistant→tool变为user→assistant→assistant，导致后续校验报错。本 PR 修复了该问题，在
messages_join_observation时也会将连续的role=assistant的内容进行合并，以避免上述问题。Experiment results
Paste your experiment result here(if needed).