-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unintentionally bundling with JUnit 3 β disable copy plugin by default #57
Conversation
Thanks for the feedback! This was intentionally added as an example in I've updated the PR to make it clear what the plugin adds, and when to enable the plugin, as Had doubted to add a link to the docs there; but at the very least the docs could point out how to configure this with Maven and point here. |
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
* Disable bundling with JUnit 3 by default * Clarify when to configure and use dependency plugin --------- Co-authored-by: Tim te Beek <[email protected]>
After having applied the latest updates to my project, i was surprised finding a JUnit 3 jar in
src/main/resources/META-INF/rewrite/classpath/
(blast from the past π ).If not actively removed this:
git add .
Therefore i propose to keep the copy plugin disabled by default, as this makes for a better DX when traded off against the above points.
Point 3. begs the question whether
src/main/resources/META-INF/rewrite/classpath/
shouldn't also be added to.gitignore
?