TEST-#5664: speedup Post Run conda-incubator/setup-miniconda@v2 step on Windows
#5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
changed the title
Post Run conda-incubator/setup-miniconda@v2 step on Windows
anmyachev
commented
Feb 15, 2023
| @@ -863,14 +863,6 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| with: | |||
| fetch-depth: 2 | |||
| - name: Cache conda | |||
There was a problem hiding this comment.
Since there is no visible result from the step and we do not save this folder with the cache, this step can be deleted.
There was a problem hiding this comment.
We should then remove this step in push.yml as well.
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Feb 15, 2023
| @@ -906,6 +898,11 @@ jobs: | |||
| run: python -m pytest modin/pandas/test/test_io.py --verbose | |||
| if: matrix.test-task == 'modin/pandas/test/test_io.py' | |||
| - uses: codecov/codecov-action@v2 | |||
| - name: Stop local ray cluster | |||
There was a problem hiding this comment.
It's good practice to explicitly release resources.
There was a problem hiding this comment.
Same thing should be done in push.yml.
|
@mvashishtha could you take a look? |
mvashishtha
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date