Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#7441: Correctly skip sanity tests if we don't need them. #7442

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Feb 14, 2025

The "sanity" tests for ray, dask, and unidist are supposed to run a subset of the "test-all" suite. If we detect a change to a particular engine, we're supposed to run the test-all job using that engine. However, if we don't detect a change, we're supposed to run the "test-sanity" job using that engine.

Prior to this commit, we always run the sanity jobs because the if key-value pairs here don't do anything. In this commit, use test matrix exclusions to skip executions that we don't need to run.

Testing

I have validated that we only run the expected sanity tests in the following scenarios, which are older commits on the branch I am trying to merge here:

Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit 8c7799f into modin-project:main Feb 14, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEST: CI never skips sanity tests
2 participants