Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support custom user model without user groups #152

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

support custom user model without user groups #152

wants to merge 1 commit into from

Conversation

gitaarik
Copy link

@gitaarik gitaarik commented Sep 30, 2021 •
edited
Loading

If no user groups exist, don't query it, so that when you use a custom
user model without groups, that you don't get an error.

Relevant GitHub Issue: #57

@gitaarik
support custom user model without user groups
fe5ff57 
If no user groups exist, don't query it, so that when you use a custom
user model without groups, that you don't get an error.

Relevant GitHub Issue:
modlinltd#57
asfaltboy
asfaltboy requested changes Jan 24, 2022
View reviewed changes
Copy link
Member

@asfaltboy asfaltboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you kindly add a test case for this scenario?

Also, please rebase over master to re-run the updated CI tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asfaltboy asfaltboy asfaltboy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitaarik @asfaltboy