Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing tailing slash #186

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: missing tailing slash #186

merged 2 commits into from
Mar 20, 2024

Conversation

YolCruz
Copy link
Contributor

@YolCruz YolCruz commented Oct 5, 2023

Closes #185

asfaltboy
asfaltboy reviewed Oct 8, 2023
View reviewed changes
Copy link
Member

@asfaltboy asfaltboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @YolCruz, but I'm not sure if it's that simple. Please see inline comment 🙏

advanced_filters/static/advanced-filters/advanced-filters.js Show resolved Hide resolved
@aukselis-c1connections
Copy link

would be awesome if this is merged!

@asfaltboy asfaltboy disabled auto-merge March 20, 2024 10:19
@asfaltboy asfaltboy merged commit 6279365 into modlinltd:develop Mar 20, 2024
9 checks passed
@asfaltboy
Copy link
Member

Thanks @aukselis-c1connections for the reminder, I had to fix up the tests and got distracted with some life changes.

And thanks again to @YolCruz for contributing the change.

@aukselis-c1connections
Copy link

@asfaltboy, thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asfaltboy asfaltboy asfaltboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid redirect when selecting a filter
3 participants
@YolCruz @aukselis-c1connections @asfaltboy