Extract getTags to own method #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn signature that I want from getTags(), but not clear how to beter return everything from the two queries. Two separate methods would be better, but there is overlap and the two are tied together. Propose and see how others want to refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had need to get the tags attached to resources, to output in XML and JSON. I did not find a way to get the raw results from the snippet, so wrote my own database query.
This small refactoring extracts the queries into a method, so they can be called on their own and the raw tag objects returned.
There is a design flaw: the count/total values are tightly coupled to the query, and I have retained them inside the method. This required a new object to be returned, rather than the raw TaggerTag iterator which I was aiming for. Right now, I have no better alternative.