Skip to content

Commit

Permalink
fix page and chunk selector in TV and Theme Settings
Browse files Browse the repository at this point in the history
Signed-off-by: matdave <[email protected]>
  • Loading branch information
matdave committed Nov 1, 2024
1 parent fe9df81 commit d1f8d11
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions _build/assets/js/Components/Sidebar/PageSettings.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,9 @@ export default class PageSettings extends SidebarPlugin {
case 'slider':
return ui.slider(setting, defaultValue, this.setThemeSettingWithEmitter);
case 'page':
return ui.page(setting, defaultValue, this.setThemeSettingWithEmitter);
return ui.page(setting, {id: defaultValue, url: ''}, this.setThemeSettingWithEmitter);
case 'chunk':
return ui.chunk(setting, defaultValue, this.setThemeSettingWithEmitter);
return ui.chunk(setting, {id: defaultValue, name: ''}, this.setThemeSettingWithEmitter);
case 'tagger':
return ui.tagger(setting, defaultValue, this.setThemeSettingWithEmitter);
case 'image':
Expand Down Expand Up @@ -361,7 +361,7 @@ export default class PageSettings extends SidebarPlugin {
fields.appendChild(ui.slider(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
break;
case 'page':
fields.appendChild(ui.page(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
fields.appendChild(ui.page(tv, { id: this.pageSettings.tvs[tv.name], url: ''}, this.setTVWithEmitter, this.addTVChangeListener));
break;
case 'tagger':
fields.appendChild(ui.tagger(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
Expand All @@ -387,7 +387,7 @@ export default class PageSettings extends SidebarPlugin {
fields.appendChild(ui.toggleGroup(tv, this.pageSettings.tvs[tv.name], this.setMultiTVWithEmitter, this.addTVChangeListener));
break;
case 'chunk':
fields.appendChild(ui.chunk(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
fields.appendChild(ui.chunk(tv, { id: this.pageSettings.tvs[tv.name], name: ''}, this.setTVWithEmitter, this.addTVChangeListener));
default:
fields.appendChild(ui.text(tv, this.pageSettings.tvs[tv.name], this.setTVWithEmitter, this.addTVChangeListener));
}
Expand Down Expand Up @@ -436,6 +436,9 @@ export default class PageSettings extends SidebarPlugin {
}

setThemeSettingWithEmitter(name, value, input) {
if (typeof value === 'object' && value.id) {
value = value.id;
}
this.setThemeSetting(name, value);

emitter.emit('fred-theme-setting-change', name, value, valueParser(value), input);
Expand Down Expand Up @@ -472,6 +475,9 @@ export default class PageSettings extends SidebarPlugin {
}

setTVWithEmitter(name, value, input) {
if (typeof value === 'object' && value.id) {
value = value.id;
}
this.setSetting(name, value, 'tvs');
emitter.emit('fred-page-setting-change', 'tv_' + name, value, valueParser(value), input);
}
Expand Down

0 comments on commit d1f8d11

Please sign in to comment.