[Enhancement] Speedup the Feed-Dashboards #13513
Conversation
| @@ -567,7 +567,7 @@ | |||
| $settings['feed_modx_security_enabled']= $xpdo->newObject('modSystemSetting'); | |||
| $settings['feed_modx_security_enabled']->fromArray(array ( | |||
| 'key' => 'feed_modx_security_enabled', | |||
| 'value' => '1', | |||
| 'value' => '0', | |||
There was a problem hiding this comment.
Why would you still leave default value as 0. Your previous PR was closed because of this or am I misreading something?
There was a problem hiding this comment.
This is me and git only slowly getting friends. Sorry. :-(
Actually I went back from "off/0" to "on/1", so the file is as was before I made changes. I reverted.
|
Besides the fact you are disabling the feeds as default, just wanted to point that this kind of optimization has already landed for 2.6 (see #13507). So not sure if we would want this in 2.5 |
| @@ -549,7 +549,7 @@ | |||
| $settings['feed_modx_news_enabled']= $xpdo->newObject('modSystemSetting'); | |||
| $settings['feed_modx_news_enabled']->fromArray(array ( | |||
| 'key' => 'feed_modx_news_enabled', | |||
| 'value' => '1', | |||
| 'value' => '0', | |||
There was a problem hiding this comment.
I think I rejected this change in previous PR :) Please change it back to enabled by default.
| @@ -567,7 +567,7 @@ | |||
| $settings['feed_modx_security_enabled']= $xpdo->newObject('modSystemSetting'); | |||
| $settings['feed_modx_security_enabled']->fromArray(array ( | |||
| 'key' => 'feed_modx_security_enabled', | |||
| 'value' => '1', | |||
| 'value' => '0', | |||
There was a problem hiding this comment.
I think I rejected this change in previous PR :) Please change it back to enabled by default.
|
@rtripault I think he forgot to change the branch and had previous commit there with feeds turned off |
|
@rtripault Yes, we do want them in 2.5.x, please cherry pick the change to this branch as well. |
|
Well, the mentioned PR does more than just "speeding up", it loads the feeds using AJAX... i don't think that qualifies to be cherry-picked into 2.5 |
|
I'd say it's a bug that it doesn't load via AJAX :P |
|
btw. just messing with you, leave it just there :) |
|
Too late, already merged 2.x back into 2.5 |
|
well I hope you didn't |
|
Nah... was messing back with you... i'm not involved with 2.5 🙌 |
|
lol, well played :P |
|
#modxbughunt #3points to @mindeffects |
|
#modxbughunt #1point to @theboxer |
What does it do?
Speeds up the dashboard widgets for the rss feeds
Why is it needed?
More speed and less overhead work if the feeds are turned off anyway.
Related issue(s)/PR(s)
none