Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reloading of lexicon entries for any namespace #16447

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

Ruslan-Aleev
Copy link
Collaborator

What does it do?

Add reloading of lexicon entries for any namespace:

  • Move the button up, it's was almost invisible.
  • Added a pop-up window with confirmation, where the namespace, topic and language are indicated.
  • The name of the strings is now returned to the console, and not just their amount.

lexicons_reload

p.s. In a good way, this PR should be improved and merged after this (#15942), although the current version is also working.

Related issue(s)/PR(s)

#16333
#14442

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Jun 18, 2023
@Ruslan-Aleev
Copy link
Collaborator Author

Guys, some time ago I deleted several PRs out of emotion, thereby devaluing not only my work, but also the work of the community.
@JoshuaLuckers @Ibochkarev @Jako @Mark-H @smg6511 I'm sorry, I'll try to restore these PRs soon so that the community's work is not lost :)

@Ruslan-Aleev Ruslan-Aleev added area-lexicons Issues related to translations and lexicons implementation. pr/review-needed Pull request requires review and testing. labels Jun 18, 2023
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 21.57%. Comparing base (73ae298) to head (6086199).
Report is 76 commits behind head on 3.x.

Files Patch % Lines
...on/Processors/Workspace/Lexicon/ReloadFromBase.php 0.00% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16447      +/-   ##
============================================
+ Coverage     21.54%   21.57%   +0.02%     
- Complexity    10563    10577      +14     
============================================
  Files           561      561              
  Lines         31910    31975      +65     
============================================
+ Hits           6876     6898      +22     
- Misses        25034    25077      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smg6511
Copy link
Collaborator

smg6511 commented Jun 18, 2023

@Ruslan-Aleev - No worries, just glad to see you're back!

@Jako
Copy link
Collaborator

Jako commented Jun 19, 2023

@Ruslan-Aleev There is no need to excuse. I understood your reaction at the end of January 2023.

Mark-H
Mark-H previously approved these changes Aug 4, 2023
@Mark-H Mark-H added this to the v3.1.0 milestone Aug 4, 2023
Copy link
Collaborator

@smg6511 smg6511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well and is a good change to the UI. I have a few suggestions (above) I'd like you to consider before approving the PR, but none are deal-breakers.

@Mark-H
Copy link
Collaborator

Mark-H commented Feb 10, 2024

After merging the grid update by @smg6511, this is now conflicting. I tried to resolve them, unsuccessfully. Would you be able to rebase?

@Ruslan-Aleev
Copy link
Collaborator Author

@Mark-H Done, check.

@opengeek opengeek merged commit 60988e8 into modxcms:3.x Mar 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-lexicons Issues related to translations and lexicons implementation. cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants