-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reloading of lexicon entries for any namespace #16447
Conversation
Guys, some time ago I deleted several PRs out of emotion, thereby devaluing not only my work, but also the work of the community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16447 +/- ##
============================================
+ Coverage 21.54% 21.57% +0.02%
- Complexity 10563 10577 +14
============================================
Files 561 561
Lines 31910 31975 +65
============================================
+ Hits 6876 6898 +22
- Misses 25034 25077 +43 ☔ View full report in Codecov by Sentry. |
@Ruslan-Aleev - No worries, just glad to see you're back! |
@Ruslan-Aleev There is no need to excuse. I understood your reaction at the end of January 2023. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well and is a good change to the UI. I have a few suggestions (above) I'd like you to consider before approving the PR, but none are deal-breakers.
After merging the grid update by @smg6511, this is now conflicting. I tried to resolve them, unsuccessfully. Would you be able to rebase? |
fc0a10b
to
25b647b
Compare
25b647b
to
c055bbf
Compare
@Mark-H Done, check. |
What does it do?
Add reloading of lexicon entries for any namespace:
p.s. In a good way, this PR should be improved and merged after this (#15942), although the current version is also working.
Related issue(s)/PR(s)
#16333
#14442